-
Notifications
You must be signed in to change notification settings - Fork 44
[QEff Finetune]: Use logger in place of print statements in finetuning scripts #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it is a good change, Mamta! Let us try to include more things as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address this one as well.
79a2115
to
2de4c6f
Compare
1fc9ef2
to
f97b24e
Compare
@mamtsing can you pls rebase and confirm if this logs file will be stored in the default qeff cache path? |
99eb8ce
to
203a358
Compare
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Use logger in place of print statements in finetuning scripts