Skip to content

[QEff Finetune]: Use logger in place of print statements in finetuning scripts #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

quic-mamta
Copy link
Contributor

Use logger in place of print statements in finetuning scripts

@quic-mamta quic-mamta requested review from quic-swatia and vbaddi and removed request for ochougul and quic-rishinr April 21, 2025 09:08
@quic-mamta quic-mamta self-assigned this Apr 21, 2025
@quic-mamta quic-mamta marked this pull request as draft April 21, 2025 09:18
Copy link
Contributor

@vbaddi vbaddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this?

Copy link
Contributor

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it is a good change, Mamta! Let us try to include more things as suggested.

Copy link
Contributor

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address this one as well.

@quic-mamta quic-mamta force-pushed the use_logger branch 3 times, most recently from 79a2115 to 2de4c6f Compare May 22, 2025 18:31
@quic-mamta quic-mamta force-pushed the use_logger branch 3 times, most recently from 1fc9ef2 to f97b24e Compare May 26, 2025 13:54
@vbaddi
Copy link
Contributor

vbaddi commented Jun 20, 2025

@mamtsing can you pls rebase and confirm if this logs file will be stored in the default qeff cache path?
We should close this PR asap!

@quic-mamta quic-mamta force-pushed the use_logger branch 4 times, most recently from 99eb8ce to 203a358 Compare June 23, 2025 12:29
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants